Cargo: No default features, selectively enable features - #153
Open
ReinierMaas wants to merge 1 commit into
Open
Conversation
ReinierMaas
marked this pull request as ready for review
July 24, 2026 15:16
OpsBotPrime
force-pushed
the
reinier/share-dependencies
branch
from
July 28, 2026 12:47
888ff06 to
c239da7
Compare
ReinierMaas
force-pushed
the
reinier/remove-default-features
branch
from
July 29, 2026 16:08
2d92cf7 to
48ae2dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XRef: #150
This removes all the default features from all our transitive dependencies.
Did I re-add all the important features that were enabled by default and that we depended on in CI.
Did I catch all the features that we only silently depended on?